Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown filter #622

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Add markdown filter #622

merged 1 commit into from
Feb 7, 2022

Conversation

Kijewski
Copy link
Collaborator

@Kijewski Kijewski commented Feb 1, 2022

No description provided.

@Kijewski
Copy link
Collaborator Author

Kijewski commented Feb 1, 2022

"expected struct std::time::Duration, found u64" seems unrelated. actix-test was updated 2h ago. I guess you should not assume a 0.1-beta version to be stable. :)

@vallentin
Copy link
Collaborator

The dependabot pr #623 also failed, so probably a change to actix-test, yeah :)

vallentin
vallentin previously approved these changes Feb 1, 2022
Copy link
Collaborator

@vallentin vallentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice. I actually have had this filter locally for ages. Don't know why I never thought of adding it. But nice! 🚀

askama_shared/src/filters/markdown.rs Outdated Show resolved Hide resolved
askama_shared/src/filters/markdown.rs Outdated Show resolved Hide resolved
@Kijewski
Copy link
Collaborator Author

Kijewski commented Feb 1, 2022

I replaced pulldown-cmark by comrak. Unsafe HTML is now sanitized by default, but the user may opt-out to allow unsafe HTML.

Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Would you mind squashing the second commit?

askama_shared/src/filters/mod.rs Outdated Show resolved Hide resolved
askama_shared/src/filters/mod.rs Show resolved Hide resolved
@Kijewski
Copy link
Collaborator Author

Kijewski commented Feb 7, 2022

I restructured the PR a bit, and I think it's quite pretty now. :)

@djc djc merged commit fd8bfa4 into rinja-rs:main Feb 7, 2022
@Kijewski Kijewski deleted the pr-markdown branch February 17, 2022 19:23
@djc djc mentioned this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants